Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-205393355
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user barryvdh commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-204806547
I can confirm this issue happening since v4.0.1 at least. v3.9.2 works fine.
All my app links now open in a separate browser window, which isn't
supposed to.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-201734157
Then LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-201656326
I put that conditional in on purpose, to be explicit in the code what the
rules are (I know the comment is in there as well) "unoptimized", it should be
fine since
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/211#issuecomment-200759257
Tested and working fine
I think the first if can be removed
```
if (allowNavigationsPass && allowIntentPass) {
return
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/211
CB-10942 - Cannot https://foo.bar; /> for linâ¦
â¦ks in that site, if you have https://*; />
You can merge this pull request into a Git repository by running:
$ git pull
