[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-06 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61998319 Sure thing. Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61902405 Had a scan over the code and nothing jumped out as unusual :). Only thing is it'd be good to use 4 space indent since that's the prevailing style everywhere else.

Re: [GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread Jesse
Next test, one of you commit a project that includes a plugin, + ios + windows platforms, and see if the other can build/run it ... @purplecabbage risingj.com On Wed, Nov 5, 2014 at 2:20 PM, martincgg wrote: > Github user martincgg commented on the pull request: > > https://github.com/apac

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61892049 Correct, I performed some testing over Windows platform, it worked like a charm. I ran some commands as: create, platform add, plugin add. After that I adde

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61886196 Thanks @shazron . I had someone test it on Windows, then I pulled their project to my Mac and made sure that the project would build and run when created from Windo

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-05 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/118#issuecomment-61882670 looks good to me for OS X, tested it lightly, I'll trust that it works on Windows (don't have capability to test it at the moment) --- If your project is set up for

[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...

2014-11-04 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/118 CB-5706 convert some of the bash scripts to nodejs only converted the ones necessary to allow iOS project management on a nonsupported OS You can merge this pull request into a Git repository