Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32742742
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32759726
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32538324
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/146#issuecomment-112483772
LGTM. Adding `glob` does increase the size of ios platform considerably.
I'm assuming there is no other cheaper way to do this.
---
If your project is set up for
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/146#discussion_r32547846
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -374,7 +374,7 @@
);
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-ios/pull/146
CB-8197 Switch to nodejs for ios platform scripts
Convert `copy-www-build-step.sh` to nodejs
Adds `glob` module and `bundledDependencies` to `package.json`
[Jira
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23372869
--- Diff: bin/lib/check_reqs.js ---
@@ -0,0 +1,94 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23372879
--- Diff: bin/lib/versions.js ---
@@ -85,17 +85,59 @@ exports.get_apple_xcode_version = function() {
child_process.exec('xcodebuild
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23372861
--- Diff: bin/lib/versions.js ---
@@ -85,17 +85,59 @@ exports.get_apple_xcode_version = function() {
child_process.exec('xcodebuild
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373146
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373137
--- Diff: bin/node_modules/nopt/.npmignore ---
@@ -0,0 +1 @@
+node_modules
--- End diff --
This file introduced by nopt, not by
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373501
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373440
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373246
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23373228
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF)
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23303819
--- Diff: bin/lib/versions.js ---
@@ -85,17 +85,59 @@ exports.get_apple_xcode_version = function() {
child_process.exec('xcodebuild -version',
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23303870
--- Diff: bin/lib/check_reqs.js ---
@@ -0,0 +1,94 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23304037
--- Diff: bin/lib/versions.js ---
@@ -85,17 +85,59 @@ exports.get_apple_xcode_version = function() {
child_process.exec('xcodebuild -version',
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23304211
--- Diff: bin/node_modules/nopt/.npmignore ---
@@ -0,0 +1 @@
+node_modules
--- End diff --
Why exclude nopt's dependencies when npm
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23304345
--- Diff: bin/node_modules/nopt/.npmignore ---
@@ -0,0 +1 @@
+node_modules
--- End diff --
Also - do you not need to check in the abbrev
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23304383
--- Diff: bin/node_modules/nopt/.npmignore ---
@@ -0,0 +1 @@
+node_modules
--- End diff --
NVM - I see it now :S
---
If your project
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23304929
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/126
CB-8197 Switch to nodejs for ios platform scripts
Implementation for [CB-8197](https://issues.apache.org/jira/browse/CB-8197)
Part of this work is already done for create/update
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23305293
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23305406
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23305562
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/126#discussion_r23305082
--- Diff: bin/templates/scripts/cordova/lib/run.js ---
@@ -0,0 +1,184 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
29 matches
Mail list logo
