[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-74345377 It should be CB-8435 (please edit the PR title). Don't worry about the commits, I can edit the commit message when pulling/squashing it in. --- If your project is s

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-13 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-74336804 The issue is finally resolved - we can go forward with this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73293570 Seems like an artifact. The original design changed and that checkin was supposed to be reverted. I'll take a look --- If your project is set up for it, you can rep

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73290860 The failing test is because your 'end-to-end list validation handles list parameter' test requires ios-sim which is not installed. Installation of ios-sim s

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73285875 `node node_modules/jshint/bin/jshint bin && node node_modules/jshint/bin/jshint tests` is passing. Failing tests are not related to this PR --- If your project is

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-05 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-ios/pull/129 CB-8412 enable jshint for iOS platform - Created a npm run jshint command & integrate into npm run test - Created jshint rules files for spec and rest of the repo - Fixed all jshint issu