[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-24 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150770063 Thanks for your feedback guys, I've opened a new PR #174. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-23 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150498299 Sounds good, can you get the code in a new pull request and reference the same CB-9685? I'll re-open it once you do so. --- If your project is set up for it, you

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150191011 BTW I am seeing it on 9.1. iPhone 6S, longpress and 3D Touch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread zhangjianying
Github user zhangjianying commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150184839 good idea. thinks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread julio cesar sanchez
Ok, forget about the -webkit-user-select: none; part, you might put that on the body but use -webkit-user-select: text; on input type text and textarea. 2015-10-22 13:03 GMT+02:00 julio cesar sanchez : > +1 for preference > > but I think the problem the plugin solves only

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150188723 +1 for preference BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe apple fixed it? --- If your project is set up for it,

Re: [GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread julio cesar sanchez
+1 for preference but I think the problem the plugin solves only appears when you add the css to avoid text selection (-webkit-user-select: none;), so if the user wants text selection he won't add that css and he doesn't need the plugin. BTW, I'm not able to reproduce the magnifier glass issue

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-22 Thread EddyVerbruggen
Github user EddyVerbruggen commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-150170110 I think I'll be adding a configuration for this to config.xml as not all folks may like this feature (new PR). The plugin that inspired this PR has

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-09 Thread Xhamps
Github user Xhamps commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-146994646 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-08 Thread zhangjianying
Github user zhangjianying commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-146428778 good ,3q 4 u time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-10-05 Thread chaffeqa
Github user chaffeqa commented on the pull request: https://github.com/apache/cordova-ios/pull/164#issuecomment-145500663 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios pull request: CB-9685 A fix for the magnifying glass p...

2015-09-22 Thread EddyVerbruggen
GitHub user EddyVerbruggen opened a pull request: https://github.com/apache/cordova-ios/pull/164 CB-9685 A fix for the magnifying glass popping up on iOS9 longpress I though `CDVLongPressFix` would not be the best name. Especially if we ever need to fix any other gestures Apple