Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155847309
Are you able to verify this works @chaffeqa?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155768503
That looks great to me! honestly i dont know how i felt about the idea of
dynamically injecting a script... call me old school ;)
Thanks guys a ton for all
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155692488
Is this sufficient in the wkwebview plugin?
```
if(window.webkit && window.webkit.messageHandler) {
module.exports = iOSExec;
}
else {
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155689767
I'll fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155613091
Good point, didn't think of that scenario. Ideally each WebView engine,
when activated, should inject its own bridge. This would solve this scenario.
We co
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155608082
I don't know if this was the path intended, but the new changes break the
falling back to UIWebView since simply including the WKWebview clobbers
`cordova.exec` (a
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/179#issuecomment-155253981
It's the Bridge of IFrame-Dûm! Good work Olórin of the Cabbages Purple
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-ios/pull/180
CB-9883
Remove last remaining alternative bridge (wk-webview)
The wk-webview plugin is now clobbering cordova.exec to provide it's own
implementation.
You can merge this pull request
Github user purplecabbage closed the pull request at:
https://github.com/apache/cordova-ios/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-ios/pull/179
CB-9883
Also remove the wk-webview bridge as the plugin itself simply clobbers
cordova.exec now.
1 Bridge! You shall not pass!
You can merge this pull request into a Git repository b
And that we need to watch what others commit. More review would have stopped
this in the first place.
> On Nov 5, 2015, at 6:33 PM, csantanapr wrote:
>
> Github user csantanapr commented on the pull request:
>
>https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526
>
>
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526
@shazron is this a lesson learned that certain experimental things should
be kept in experimental branches and not in master :+1:
---
If your project is set up
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/178#issuecomment-153908591
IFRAME_NAV has always worked from the beginning and has been the default,
the other bridge modes are experimental to try to gain speed, but flakey --
like the comme
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/178#issuecomment-153887028
With this removal, is there a minimum ios version that this will work only
using the IFRAME_NAV bridge?
---
If your project is set up for it, you can reply to t
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/178
CB-9883 - Remove unused iOS bridges
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-9883
Alternativel
17 matches
Mail list logo
