Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958989
So it does! I'll rebase now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958943
Ah, sorry. However as you can see in this pull request, according to Github
your PR has merge conflicts that need to be re-based.
---
If your project is set up for
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58958702
They're compound changes. There are changes in the JS *and* the native
layer. I've reverted the JS changes here, but the native code changes remain.
---
If your
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58957912
I meant that you've already submitted a PR to cordova-js
(https://github.com/apache/cordova-js/pull/84), this one is obsolete because it
is not the right repo.
---
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58957206
Are we not going to merge it? Sorry, it's been a while and I don't
remember the exact order of things for getting changes into the repo.
---
If your project is se
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58952165
Thanks Kevin, can you close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58263722
@shazron Okay, I think I got everything worked out wrt cordova-js, and
reverting here.
---
If your project is set up for it, you can reply to this email and have y
Github user khawkins commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58258046
Ah, thanks @shazron , I'll clear it here, and submit that one over there.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/112#issuecomment-58256220
Hi @khawkins the cordova.js stuff should actually be in the cordova-js
repo: http://github.com/apache/cordova-js
The file you see here is dynamically generated
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/112#discussion_r18433085
--- Diff: CordovaLib/cordova.js ---
@@ -1017,7 +1010,7 @@ function pokeNativeViaXhr() {
// Add a timestamp to the query param to prevent caching
Github user khawkins commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/112#discussion_r18433084
--- Diff: CordovaLib/cordova.js ---
@@ -918,15 +918,8 @@ function convertMessageToArgsNativeToJs(message) {
}
function iOSExec() {
-
GitHub user khawkins opened a pull request:
https://github.com/apache/cordova-ios/pull/112
Creating a customizable user agent for iOS
Fix for [CB-2520](https://issues.apache.org/jira/browse/CB-2520).
Presumably, we'd eventually want a more user-exposed entry path to this. But
this
13 matches
Mail list logo
