[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-10-02 Thread lyonplus
Github user lyonplus commented on the pull request: https://github.com/apache/cordova-ios/pull/106#issuecomment-57595003 Thanks for all the hardworking, shazron! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-10-02 Thread lyonplus
Github user lyonplus closed the pull request at: https://github.com/apache/cordova-ios/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-10-01 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/106#issuecomment-57590952 Thanks! Tested and pulled in. https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=2ba35b1 You can close this PR now --- If your project is set up for it

[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-09-24 Thread lyonplus
Github user lyonplus commented on the pull request: https://github.com/apache/cordova-ios/pull/106#issuecomment-56726607 shazron: thanks so much and sorry for not having done it myself! --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-09-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894 Per CONTRIBUTING.md, a JIRA issue should have been filed. I have filed it for you: https://issues.apache.org/jira/browse/CB-7627 --- If your project is set up for i

[GitHub] cordova-ios pull request: Remove duplicate reference to the same l...

2014-09-24 Thread lyonplus
GitHub user lyonplus opened a pull request: https://github.com/apache/cordova-ios/pull/106 Remove duplicate reference to the same libCordova.a. libCordova.a has already been referred to as a framework, no need to force_load it again. Normally it is OK to refer to libCord