GitHub user edewit reopened a pull request:
https://github.com/apache/cordova-ios/pull/104
generates a workspace instead of subproject
Initial part of [CB-5921](https://issues.apache.org/jira/browse/CB-5921)
You can merge this pull request into a Git repository by running:
$ gi
Github user edewit commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-179434508
The initial idea was to be able to support swift plugins. This is now fixed
by changing build.xconfig. For cocoapods this pr could still be relevant
---
If your pr
Github user yjukaku commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-178796116
@edewit Can you please clarify what you mean? To be able to use CocoaPods,
we still need a workspace to be generated instead of a project with a
sub-project.
---
Github user edewit closed the pull request at:
https://github.com/apache/cordova-ios/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user edewit commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-82403994
now that swift options are added is this still relevant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user edewit commented on the pull request:
https://github.com/apache/cordova-ios/pull/104#issuecomment-59985149
Thanks @shortstuffsushi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19172620
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -38,25 +37,9 @@
7E7966E61810823500FA85AD /* icon-small.pn
Github user edewit commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19148970
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -38,25 +37,9 @@
7E7966E61810823500FA85AD /* icon-small.png in Reso
Github user edewit commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19148848
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -476,6 +426,10 @@
GCC_VERSION = "";
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19095095
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -507,6 +461,10 @@
GCC_VERSION = "";
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19095258
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -476,6 +426,10 @@
GCC_VERSION = "";
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19095215
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -38,25 +37,9 @@
7E7966E61810823500FA85AD /* icon-small.pn
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19095059
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -476,6 +426,10 @@
GCC_VERSION = "";
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19095003
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -38,25 +37,9 @@
7E7966E61810823500FA85AD /* icon-small.pn
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19094048
--- Diff:
bin/templates/project/__PROJECT_NAME__.xcworkspace/contents.xcworkspacedata ---
@@ -0,0 +1,10 @@
+
+
+
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19093263
--- Diff: bin/create ---
@@ -110,6 +110,9 @@ else
cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj"
"$PROJECT_PATH/$PROJECT_NAME.xcode
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19091211
--- Diff: bin/create ---
@@ -110,6 +110,9 @@ else
cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj"
"$PROJECT_PATH/$PROJECT_NAME.xcode
Github user edewit commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19069556
--- Diff: bin/create ---
@@ -110,6 +110,9 @@ else
cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj"
"$PROJECT_PATH/$PROJECT_NAME.xcodeproj"
Github user edewit commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r19069510
--- Diff: bin/create ---
@@ -110,6 +110,9 @@ else
cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj"
"$PROJECT_PATH/$PROJECT_NAME.xcodeproj"
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r18967247
--- Diff: bin/create ---
@@ -110,6 +110,9 @@ else
cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj"
"$PROJECT_PATH/$PROJECT_NAME.xcode
Github user shortstuffsushi commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/104#discussion_r18967305
--- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj ---
@@ -507,6 +461,10 @@
GCC_VERSION = "";
GitHub user edewit opened a pull request:
https://github.com/apache/cordova-ios/pull/104
generates a workspace instead of subproject
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edewit/cordova-ios workspace
Alternatively you
22 matches
Mail list logo