[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-08-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-08-04 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-js/pull/124#issuecomment-127799631 Merge away! Thanks again. Love the refactor. Way simpler to read and follow. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-08-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/124#discussion_r36251972 --- Diff: tasks/lib/packager-browserify.js --- @@ -46,25 +37,13 @@ module.exports = function generate(platform, useWindowsLineEndings, platformVe

[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-08-03 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/124#discussion_r36151389 --- Diff: tasks/lib/bundle-browserify.js --- @@ -19,53 +19,63 @@ var fs = require('fs'); var path = require('path'); va

[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-08-03 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/124#discussion_r36151308 --- Diff: tasks/lib/packager-browserify.js --- @@ -46,25 +37,13 @@ module.exports = function generate(platform, useWindowsLineEndings, platformVers

[GitHub] cordova-js pull request: CB-9436 Refactor browserify to get rid of...

2015-07-31 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-js/pull/124 CB-9436 Refactor browserify to get rid of `require-tr` transform This PR removes excess `require-tr` browserify transform and makes resultant bundle compatible with mobilespec and proba