Github user stevengill commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-167609548
@dblotsky Did you get the server back up after you got the VM rebuilt?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-167609442
@dblotsky, did we get the server back up?
On Mon, Dec 21, 2015 at 2:07 AM, Sergey Shakhnazarov <
notificati...@github.com> wrote:
> Merged.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-labs/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-166258381
Merged. @dblotsky, @stevengill, could you please update the server?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/12#discussion_r48029125
--- Diff: server.js ---
@@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÃÃÃøøø¼';
var Iconv = require('iconv').Iconv;
var iconv = new
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/12#discussion_r48029078
--- Diff: server.js ---
@@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÃÃÃøøø¼';
var Iconv = require('iconv').Iconv;
var iconv = new
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-165798576
@dblotsky, thanks for reviewing!
[Addressed](https://github.com/daserge/cordova-labs/commit/091d64c57cb35ce3fe21042821abb30aad2bcb2a),
please take a look.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-labs/pull/12#discussion_r48029256
--- Diff: server.js ---
@@ -11,6 +12,54 @@ var LATIN1_SYMBOLS = '¥§©ÃÃÃøøø¼';
var Iconv = require('iconv').Iconv;
var iconv = new
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-165908889
LGTM. Thanks for addressing the comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user daserge commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-165413593
@dblotsky, @jasongin, @stevengill, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
10 matches
Mail list logo
