[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r47014925 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-labs/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46923612 --- Diff: server.js --- @@ -78,6 +90,17 @@ http.createServer(function (req, res) { res.end("\n"); }); }

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46923583 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert f

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46873919 --- Diff: server.js --- @@ -78,6 +90,17 @@ http.createServer(function (req, res) { res.end("\n"); });

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-labs/pull/10#discussion_r46872038 --- Diff: server.js --- @@ -6,6 +6,11 @@ var formidable = require('formidable'), var DIRECT_UPLOAD_LIMIT = 32; // bytes +// convert

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-162630500 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-07 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-162485970 @dblotsky, @stevengill, I would like to merge this in tomorrow if there are no objections. --- If your project is set up for it, you can reply to this email and ha

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/10#issuecomment-161955467 @dblotsky, @stevengill could please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-labs pull request: CB-9840 Fallback file-transfer uploadRe...

2015-12-04 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/10 CB-9840 Fallback file-transfer uploadResponse encoding to latin1 in c… …ase not encoded with UTF-8 on iOS Adds non-utf endpoints for the correspoding tests: [filetransfer.spec.36](