[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2017-03-10 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/260 I think we can close this since its already in the Platform API for cordova-ios, and users will have to upgrade if they want this fix for cordova-ios < 4. --- If your project is set up for

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2017-03-09 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/260 I believe we are deleting ios_parser.js for cordova@7 since that functionality has all been moved into cordova-ios platform now. This would only be useful for older versions of cordova-ios

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-30 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 Thanks, @shazron. I've rebased this pr and opened a new one here https://github.com/apache/cordova-ios/pull/233 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-30 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/260 ## [Current coverage][cc-pull] is **80.58%** > Merging [#260][cc-pull] into [master][cc-base-branch] will decrease coverage by **0.01%** ```diff @@ master

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-23 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/260 @cjpearson unfortunately this patch can't be applied since the code has changed. Can you re-work it based on the master code? Also, the code you are trying to patch is the default fallback if a

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-17 Thread cjpearson
Github user cjpearson commented on the issue: https://github.com/apache/cordova-lib/pull/260 @shazron, could you please take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...

2016-06-17 Thread mattrayner
Github user mattrayner commented on the issue: https://github.com/apache/cordova-lib/pull/260 I'm guessing there's no news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this