[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-10-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/504 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/504?src=pr) is 80.62% (diff: 100%) > Merging [#504](https://codecov.io/gh/apache/cordova-lib/pull/504?src=pr) into [ma

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-10-19 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/504 Make sure to run `npm test` before re-submitting your changes. CI fail due to jshint error. `src/plugman/fetch.js: line 72, col 12, 'option' is not defined.` --- If your project is set up f

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-10-20 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/504 This PR can be closed now! It was merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 This fix has issue now since ``` options.subdir = options.subdir || '.'; ... if (result[2]) options.subdir = result[2]; // not work if it is empty ... if(options.subdir)

[GitHub] cordova-lib issue #504: CB-11979 added deprecation warning for subdirectorie...

2016-12-16 Thread yyfearth
Github user yyfearth commented on the issue: https://github.com/apache/cordova-lib/pull/504 I have create RP #511 CB-12261 to fix the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th