[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user alexreg commented on the issue: https://github.com/apache/cordova-lib/pull/558 Surely the whitespace settings should simply be maintained, like NPM/Yarn does? i.e. if it's already using tabs, keep tabs, and keep the number of spaces being used. ---

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-lib/pull/558 There is also https://issues.apache.org/jira/browse/CB-13009, they are similar, not sure if duplicated --- - To

Re: [GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...,

,, On Tue, May 16, 2017 at 12:20 PM stevengill wrote: > Github user stevengill commented on the issue: > > https://github.com/apache/cordova-lib/pull/558 > > really good point. We should switch to two like npm. > > > --- > If your project is set up for it, you can

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 Hey @G-Rath CB-12810 is very much still open :). https://issues.apache.org/jira/browse/CB-12810 Thanks for your comment. This is something we will hopefully get to soon.

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user G-Rath commented on the issue: https://github.com/apache/cordova-lib/pull/558 @stevengill I really agree with @uloco - Not only for the reason of consistent, but because the constant removal of the last line is picked up by VCSs, which can be really annoying.

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 You should also keep the last line if it's empty in both, `package.json` and `config.xml`. The [POSIX

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 @stevengill Go for it. I don't have an account there... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 @uloco want to add your comment to this issue: https://issues.apache.org/jira/browse/CB-12810 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user uloco commented on the issue: https://github.com/apache/cordova-lib/pull/558 When adding platforms or plugins, you also perform a config.xml rewrite. Will this merge affect config.xml indentation rewrites, too? I do use 2 space indentation everywhere. It would be nice if

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/558 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user purplecabbage commented on the issue: https://github.com/apache/cordova-lib/pull/558 +1, let's merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user mraerino commented on the issue: https://github.com/apache/cordova-lib/pull/558 Is this going to be merged? The current behavior really messes up my workflow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user remcohaszing commented on the issue: https://github.com/apache/cordova-lib/pull/558 @piotrowski I did a regex replace to replace all occurrences of `JSON.stringify`, so basically this affects all JSON files that are modified by Cordova. I think this is a pretty

[GitHub] cordova-lib issue #558: CB-12766 Consistently write JSON with 2 spaces inden...

Github user piotrowski commented on the issue: https://github.com/apache/cordova-lib/pull/558 Which files will this affect? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature