[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84998011 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997761 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997132 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-25 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r84997032 --- Diff: cordova-lib/spec-cordova/package.json.spec.js --- @@ -0,0 +1,389 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread sterlingann
Github user sterlingann closed the pull request at: https://github.com/apache/cordova-lib/pull/504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread sterlingann
Github user sterlingann commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84335445 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84220720 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r84220511 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) { if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r83974505 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) { //if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/504#discussion_r83974283 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) { //if

[GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...

2016-10-18 Thread sterlingann
GitHub user sterlingann opened a pull request: https://github.com/apache/cordova-lib/pull/504 CB-11979 added deprecation warning for subdirectories ### Platforms affected all ### What does this PR do? warns of deprecation of subdirectories in

[GitHub] cordova-lib pull request #484: [CB-11730] Modify condition of if clause to a...

2016-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/498 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...

2016-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #484: [CB-11730] Modify condition of if clause to a...

2016-10-14 Thread ahirun0426
Github user ahirun0426 commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/484#discussion_r83387722 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -330,7 +330,7 @@ function copyPlugin(pinfo, plugins_dir, link) { shell.rm('-rf',

[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #501: CB-11951 CB-11967: Respect preference default...

2016-10-13 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/501#discussion_r83341216 --- Diff: cordova-lib/spec-cordova/plugin.spec.js --- @@ -203,6 +204,23 @@ describe('plugin end-to-end', function() { .fin(done);

[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/503 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #503: CB-11994 - appveyor tests on cordova-lib are ...

2016-10-12 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/503 CB-11994 - appveyor tests on cordova-lib are not testing on all node versions ### Platforms affected Self ### What does this PR do? appveyor.yml wasn't testing on

[GitHub] cordova-lib pull request #502: CB-12002 - Add getAllowIntents() to ConfigPar...

2016-10-12 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/502 CB-12002 - Add getAllowIntents() to ConfigParser ### Platforms affected None, but I'm adding this as preparation for an iOS feature. ### What does this PR do? Adds a convenience

[GitHub] cordova-lib pull request #501: CB-11951 CB-11990 CB-11967: Respect preferenc...

2016-10-12 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/501 CB-11951 CB-11990 CB-11967: Respect preference default values when install plugin ### What does this PR do? Respects preference default values when install plugin

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-11 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/499#discussion_r82916012 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -298,8 +326,24 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request #500: CB-11998 - cordova platform add error with co...

2016-10-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #500: CB-11998 - cordova platform add error with co...

2016-10-11 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/500 CB-11998 - cordova platform add error with cordova-common@1.5.0 ### Platforms affected All platforms. ### What does this PR do? Fixes "ENOENT: no such file or

[GitHub] cordova-lib pull request #499: Cb 11960

2016-10-10 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/499 Cb 11960 ### Platforms affected Will work when adding all platforms. ### What does this PR do? When adding or removing a platform (with --save), the specified

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82568768 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) { }

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-10 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82566198 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -72,4 +75,53 @@ function restoreSettings() { } } +/** + * Fetches the

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82563323 --- Diff: cordova-lib/src/util/npm-helper.js --- @@ -72,4 +75,53 @@ function restoreSettings() { } } +/** + *

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/498#discussion_r82563870 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises) { }

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

2016-10-10 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-lib/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #498: CB-11985 Check if cached platform/plugin exis...

2016-10-07 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/498 CB-11985 Check if cached platform/plugin exists before 'npm cache' ### What does this PR do? Before calling `npm cache add` when installing a platform or plugin, look for an existing

[GitHub] cordova-lib pull request #497: CB-11976 - Add deprecated node version warnin...

2016-10-07 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/497 CB-11976 - Add deprecated node version warning for 0.x ### Platforms affected All ### What does this PR do? Prints out a warning on `prepare` that you are using a

[GitHub] cordova-lib pull request #491: CB-11776 Add test case for different edit-con...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #492: CB-11908 Add edit-config to config.xml

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #493: CB-11908 Handle edit-config in config.xml on ...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #496: CB-11936 - Support four new App Transport Sec...

2016-10-06 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/496 CB-11936 - Support four new App Transport Security (ATS) keys ### Platforms affected iOS ### What does this PR do? This PR is to support the feature in

[GitHub] cordova-lib pull request #495: CB-8995 renamed start to plugman install/unin...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #495: CB-8995 renamed start to plugman install/unin...

2016-10-04 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/495 CB-8995 renamed start to plugman install/uninstall start to make Cord… CB-8995 renamed "start" to "plugman install/uninstall start" to make CordovaLib tests more descriptive You can merge

[GitHub] cordova-lib pull request #494: Documentation for using cordova-lib with gulp

2016-09-30 Thread mspace
Github user mspace closed the pull request at: https://github.com/apache/cordova-lib/pull/494 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #494: Documentation for using cordova-lib with gulp

2016-09-29 Thread mspace
GitHub user mspace opened a pull request: https://github.com/apache/cordova-lib/pull/494 Documentation for using cordova-lib with gulp Is there any documentation available or will be for using cordova-lib with gulp tasks. For example ```javascript

[GitHub] cordova-lib pull request #493: CB-11908 Handle edit-config in config.xml on ...

2016-09-26 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/493 CB-11908 Handle edit-config in config.xml on prepare Needs this PR: https://github.com/apache/cordova-lib/pull/492 You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request #492: CB-11908 Add edit-config to config.xml

2016-09-26 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/492 CB-11908 Add edit-config to config.xml Handles edit-config for config.xml. Fixed up the conflict checking so that config.xml will take precedence over plugin.xml changes. Added a

[GitHub] cordova-lib pull request #490: Android studio

2016-09-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #490: Android studio

2016-09-22 Thread imhotep
Github user imhotep commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/490#discussion_r80154885 --- Diff: cordova-lib/src/platforms/platforms.js --- @@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {

[GitHub] cordova-lib pull request #490: Android studio

2016-09-22 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/490#discussion_r80110771 --- Diff: cordova-lib/src/platforms/platforms.js --- @@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {

[GitHub] cordova-lib pull request #490: Android studio

2016-09-16 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/490#discussion_r79263894 --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js --- @@ -193,6 +193,11 @@ function resolveConfigFilePath(project_dir, platform, file) {

[GitHub] cordova-lib pull request #490: Android studio

2016-09-16 Thread imhotep
GitHub user imhotep opened a pull request: https://github.com/apache/cordova-lib/pull/490 Android studio Adds Android Studio support Adds some logging for when patformApi fails for weird reasons. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #489: CB-11811 - Updated travis settings

2016-09-08 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/489 CB-11811 - Updated travis settings EXPERIMENTING. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib CB-11811

[GitHub] cordova-lib pull request #478: CB-11607 breakout cordova-create from cordova...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/478 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #488: CB-11517 Allow .folder matches

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #486: CB-11776 check edit-config target exists

2016-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #488: CB-11517 Allow .folder matches

2016-08-30 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/488 CB-11517 Allow .folder matches You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-lib CB-11517 Alternatively you

[GitHub] cordova-lib pull request #486: CB-11776 check edit-config target exists

2016-08-26 Thread ktop
GitHub user ktop opened a pull request: https://github.com/apache/cordova-lib/pull/486 CB-11776 check edit-config target exists Missing a case in the conflict checking for edit-config. If the target doesn't exist in .json, and cannot resolve to an existing target, then no conflict

[GitHub] cordova-lib pull request #485: CB-11771 Deep symlink directories to target p...

2016-08-26 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/485 CB-11771 Deep symlink directories to target project instead of linking the directory itself When installing a plugin with custom library using the --link option the whole directory is

[GitHub] cordova-lib pull request #484: [CB-11730] Modify condition of if clause to a...

2016-08-22 Thread ahirun0426
GitHub user ahirun0426 opened a pull request: https://github.com/apache/cordova-lib/pull/484 [CB-11730] Modify condition of if clause to avoid similar project nam… …e with plugin name The original if clause accepts c:\work\SimplePlugin_TestBed with

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #481: CB-9825 - framework tag spec parsing

2016-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/481 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #483: CB-11724 - Tests on appveyor are not using di...

2016-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #483: CB-11724 - Tests on appveyor are not using di...

2016-08-18 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/483 CB-11724 - Tests on appveyor are not using different versions of node You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-lib

[GitHub] cordova-lib pull request #482: CB-11723 - Tests on Travis are not using the ...

2016-08-18 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/482 CB-11723 - Tests on Travis are not using the latest 4.x and 6.x versions of node You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #481: CB-9825 framework tag spec parsing

2016-08-18 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/481 CB-9825 framework tag spec parsing Squashed PR from https://github.com/apache/cordova-lib/pull/467 and will add my fixes on top of it. You can merge this pull request into a Git repository

[GitHub] cordova-lib pull request #479: CB-11698 Fix plugin installation when restori...

2016-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...

2016-08-16 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/480#discussion_r74917605 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -37,23 +37,25 @@ function prepare(options) { return Q().then(function() { var

[GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...

2016-08-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/480#discussion_r74823439 --- Diff: cordova-lib/src/cordova/prepare.js --- @@ -37,23 +37,25 @@ function prepare(options) { return Q().then(function() {

[GitHub] cordova-lib pull request #480: CB-11687 platform-specific plugin prepare hoo...

2016-08-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/480 CB-11687 platform-specific plugin prepare hooks should be run even wh… …en no platforms are specified DO NOT MERGE YET, discussion is needed See details in

[GitHub] cordova-lib pull request #479: CB-11698 Fix plugin installation when restori...

2016-08-12 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/479 CB-11698 Fix plugin installation when restoring platform This partially reverts #464 and forces cordova to always check for and install plugins, added to the project, to platform that

[GitHub] cordova-lib pull request #478: CB-11607 breakout cordova-create from cordova...

2016-08-12 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/478 CB-11607 breakout cordova-create from cordova-lib Waiting on [cordova-create](https://github.com/apache/cordova-create) release on npm. Will need to update package.json. You can merge

[GitHub] cordova-lib pull request #477: CB-11688 Fix platform.spec timeout errors

2016-08-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/477 CB-11688 Fix platform.spec timeout errors [Jira issue](https://issues.apache.org/jira/browse/CB-11688) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #476: CB-11679 Speed up save/restore tests

2016-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/476 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #466: Add general purpose ConfigParser.getAttribute...

2016-08-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #476: CB-11679 Speed up save/restore tests

2016-08-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/476 CB-11679 Speed up save/restore tests JIRA issue [CB-11679](https://issues.apache.org/jira/browse/CB-11679) You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #462: CB-8151 util.js creates directory if require(...

2016-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/462 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

2016-08-02 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/475#discussion_r73153070 --- Diff: cordova-lib/src/cordova/emulate.js --- @@ -42,20 +46,17 @@ module.exports = function emulate(options) { }).then(function() {

[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build

2016-08-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/475 CB-11652 Update run and emulate to skip build This PR moves handling of `--nobuild` option to CLI. CLI previously has delegated this logic to platform's `run` method but since

[GitHub] cordova-lib pull request #459: CB-11493: Add cordova emulate option to skip ...

2016-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #470: CB-11636 Handle attributes with quotes correc...

2016-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/470 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #473: CB-11645 added check to see if getEditConfig ...

2016-08-01 Thread stevengill
Github user stevengill closed the pull request at: https://github.com/apache/cordova-lib/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request #474: CB-11653 copied findProjectRoot from cordova-...

2016-08-01 Thread carynbear
GitHub user carynbear opened a pull request: https://github.com/apache/cordova-lib/pull/474 CB-11653 copied findProjectRoot from cordova-lib; ToDo: migrate tests… … over You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #472: CB-11645: Check for getEditConfigs before inv...

2016-07-29 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-lib/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #473: CB-11645 added check to see if getEditConfig ...

2016-07-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/473 CB-11645 added check to see if getEditConfig exists before trying to … …use it Please review @macdonst @vladimir-kotikov @ktop. I am not familiar enough with these new changes.

[GitHub] cordova-lib pull request #472: CB-11645: Check for getEditConfigs before inv...

2016-07-29 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-lib/pull/472 CB-11645: Check for getEditConfigs before invoking it on pluginInfo Adding a guard to prevent a type error when platforms and CLI have mismatching cordova-common versions. The issue here is

[GitHub] cordova-lib pull request #471: CB-11205 fix bug restore plugin with variable...

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #471: CB-11205 fix bug restore plugin with variable...

2016-07-29 Thread matrosovN
GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-lib/pull/471 CB-11205 fix bug restore plugin with variables via 'plugin add' command You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...

2016-07-28 Thread infil00p
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/469#discussion_r72688890 --- Diff: cordova-lib/src/cordova/metadata/android_parser.js --- @@ -31,14 +31,20 @@ var fs= require('fs'), function

[GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...

2016-07-28 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/469#discussion_r72685014 --- Diff: cordova-lib/src/cordova/metadata/android_parser.js --- @@ -31,14 +31,20 @@ var fs= require('fs'), function

[GitHub] cordova-lib pull request #470: CB-11636 Handle attributes with quotes correc...

2016-07-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/470 CB-11636 Handle attributes with quotes correctly This PR changes `mergeXml` inner implementation to avoid using `elementtree.findall()` with complex queries such as

[GitHub] cordova-lib pull request #469: CB-8320: We look for a build.gradle to make s...

2016-07-28 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-lib/pull/469 CB-8320: We look for a build.gradle to make sure it's Android, this allows plugman to be used with non-standard Cordova projects. You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72543969 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72543906 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #468: CB-8978 Add resource-file parsing to config.x...

2016-07-27 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/468 CB-8978 Add resource-file parsing to config.xml Original JIRA issue https://issues.apache.org/jira/browse/CB-8978 Related to/replaces https://github.com/apache/cordova-lib/pull/214 See

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72542674 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72541227 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72541191 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538340 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538273 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538178 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538082 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

<    1   2   3   4   5   6   7   8   9   10   >