Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-63091257
Finally had the chance to review and test this. Looks good; tests fine; I'm
merging it in to master.
---
If your project is set up for it, you can reply to this em
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-63012342
ping @clelland @agrieve again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-62823008
ping @clelland @agrieve Could you please help to take a look, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user fujunwei closed the pull request at:
https://github.com/apache/cordova-lib/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/119#issuecomment-62672178
The Cordova 4.0 have the same feature as "Android: Add library projects to
gradle build config"
(https://github.com/apache/cordova-lib/commit/8a2ca58394ed72423ece7b
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/119
Add a type named "gradleReference" in framework
It's too complex to dependence AAR in plugin, it need build the plugin
to a android project which include AndroidManifest.xml. This patch
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62096240
> Tests should be updated with this as well (although they were failing on
the branch before this PR)
There are no settings.gradle and libraries.gradle files in
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62082241
I think we should add the two lines automatically when upgrade the project.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62038387
Pushed to apache/cordova-android as well, on a new CB-3445 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62037534
I've rebased this against master now, and pushed it up on a feature branch
(`CB-3445-2`, to not conflict with the previous branch)
---
If your project is set up fo
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62037845
Tests should be updated with this as well (although they were failing on
the branch before this PR)
---
If your project is set up for it, you can reply to this ema
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62033701
What happens on upgrade, if a project already has a
`platforms/android/build.gradle` file? Do we need to put some code in to either
replace build.gradle or add the
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-62004988
Sorry, Junwei -- I meant to take a look at this when you first posted it.
This looks good; I'm going to test it out with the Crosswalk AAR, and I'll
merge i
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61920987
@agrieve @clelland PTAL. Thanks.
The blow section will commit to ./bin/remplates/project/build.gradle
// PLUGIN GRADLE EXTENSIONS START
// PLUGIN GRA
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61446454
ping @clelland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-61198123
hi @clelland , Could you give some suggestion on the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60540658
hi @clelland, Is it a good approach to use Maven library in plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-lib/pull/111#issuecomment-60359665
@clelland PTAL. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-lib/pull/111
Add a type named "gradleReference" in framework
It's too complex to dependence AAR in plugin, we need build the plugin to a
android project which include AndroidManifest.xml. This patch is app
20 matches
Mail list logo
