Sure, Jesse.
Best regards, Vladimir.
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Wednesday, August 26, 2015 3:58 AM
To: dev@cordova.apache.org
Subject: Re: [GitHub] cordova-lib pull request: Adds implementation for
PlatformApiPoly ...
This looks great, but I
This looks great, but I would like to spend a little more time before we
push it to master.
Can we hold off until the end of the week?
My team is hiring!
@purplecabbage
risingj.com
On Tue, Aug 25, 2015 at 5:46 PM, stevengill wrote:
> Github user stevengill commented on the pull request:
>
>
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/282#issuecomment-134780081
Looks great Vlad! I'm fine with you merging this in and us spending some
time testing it on master to make sure it works with all of our platforms.
---
If you
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/282#issuecomment-134241500
Thanks for advice, Mark. I have some plans about tests update and
definitely will try fixtures-based approach.
---
If your project is set up for it, you c
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/282#discussion_r37758129
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -168,22 +167,18 @@ function remove_plugin_changes(plugin_name,
plugin_id, is_top
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/282#issuecomment-134217638
Looks good! and very clean.
One note about tests, jasmine spies seem to give you a lot of trouble. In
the previous refactoring round I was doing, I found it
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/282
Adds implementation for PlatformApiPoly class according to PlatformApi spec
This implements PlatformApiPoly class according to PlatformApi spec, which
allows to:
* create/update
