Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-190575330
We need to add this to the docs. @andorman - Could you submit a PR to this
page?
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189269844
@andorman, i'll take care of tests. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189176531
LGTM. @andorman, It'd be great if you could add a couple of tests for this?
@nikhilkh, it looks like `target` attribute for images is not
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/392#issuecomment-189058742
@vladimir-kotikov to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-lib/pull/392
CB-10622 fix target attribute being ignored for images in config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-lib
Github user andorman closed the pull request at:
https://github.com/apache/cordova-lib/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
