Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53677145
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var pl
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53669157
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user tony-- commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53622685
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var pl
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186517246
It looks great assuming that before_platform_add and after_platform_add
hooks could be platform specific.
My understanding about the current convention is a li
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545261
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545199
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user bso-intel commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/395#discussion_r53545185
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -79,148 +79,156 @@ function addHelper(cmd, hooksRunner, projectRoot,
targets, opts) {
var
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186428877
@bso-intel will you take a look, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user tony-- commented on the pull request:
https://github.com/apache/cordova-lib/pull/395#issuecomment-186425912
I'd like to see this get fixed, so I thought I'd submit a PR, but I'm a
node noob - this definitely needs to be reviewed before being merged in.
---
If your projec
GitHub user tony-- opened a pull request:
https://github.com/apache/cordova-lib/pull/395
CB-10654 make hooks fire when platforms added from repo or dir
move `hooksRunner.fire('before_platform_'...) ` till after platform has
been resolved, pass resolved platform instead of target.
10 matches
Mail list logo
