[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

2016-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

2016-02-25 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54081599 --- Diff: cordova-lib/src/plugman/platforms/browser.js --- @@ -31,25 +29,7 @@ module.exports = { return path.join(project_dir, 'www'

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

2016-02-25 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/398#issuecomment-188730806 Thanks @vladimir-kotikov - looks good. Just a couple of suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

2016-02-25 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54079687 --- Diff: cordova-lib/src/plugman/platforms/browser.js --- @@ -31,25 +29,7 @@ module.exports = { return path.join(project_dir, 'www');

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

2016-02-25 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/398#discussion_r54079611 --- Diff: cordova-lib/src/plugman/platforms/common.js --- @@ -22,7 +22,39 @@ var shell = require('shelljs'), fs= require('fs'), co