[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/428#discussion_r60380149 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) { // assume it

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/428#issuecomment-212067153 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-19 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/428#issuecomment-212000688 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-19 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/428#discussion_r60261791 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) { // assume it is the

[GitHub] cordova-lib pull request: CB-10761 Resore plugins saved without sp...

2016-04-19 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/428 CB-10761 Resore plugins saved without spec attribute This PR updates plugin restore logic to restore plugins that were added to plugin.xml without `spec` attribute. See [CB-10761](htt