[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-208511405 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59224471 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to direct

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-208400534 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207640986 Yes, I'm aware he is removing npm cache completely. This fix is still valuable in the interim till Steve completes the fetch work. --- If your project is set up f

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/422#issuecomment-207526774 I think Steve is addressing this in his changes to fetch. Cc: @stevengill --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59051171 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to direc

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-08 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/422#discussion_r59007596 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -147,10 +147,7 @@ function cordova_npm(platform) { // Returns a promise that resolves to direct

[GitHub] cordova-lib pull request: CB-10770 Remove cache-min when adding pl...

2016-04-07 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-lib/pull/422 CB-10770 Remove cache-min when adding platforms You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib cache-min Alternat