Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197159034
still working on integrating it into the template work, but will add it
soon to the pr.
On Tue, Mar 15, 2016 at 8:00 PM, Carlos Santana
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197128552
@stevengill the npm install portion is reverted now, I will take a look at
your PR for npm fetch on how is handling the template fetching and npm install.
---
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197123180
@stevengill oops good catch, that npm install portion was not suppose to be
there, I was just experimenting, only the top portion for the sub dir.
I
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197038950
I don't think you should be running npm install carlos. This code doesn't
even check if npm exists before trying to run it.
I recommend you leaving the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/410
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-196831845
@vladimir-kotikov thanks for the review I will check on those
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-196699443
LGTM apart from two minor nitpicks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/410#discussion_r56123679
--- Diff: cordova-lib/src/cordova/create.js ---
@@ -220,8 +220,22 @@ function create(dir, optionalId, optionalName, cfg) {
}
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/410#discussion_r56122825
--- Diff: cordova-lib/src/cordova/create.js ---
@@ -220,8 +220,22 @@ function create(dir, optionalId, optionalName, cfg) {
}
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-196399690
@stevengill @vladimir-kotikov could you review this when you have chance.
---
If your project is set up for it, you can reply to this email and have your
reply
10 matches
Mail list logo
