Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/418#issuecomment-202768180
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/418#issuecomment-202764912
Addressed, thanks @vladimir-kotikov, please take a look when you have a
moment.
---
If your project is set up for it, you can reply to this email and have your
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57676830
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57673750
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57673594
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if (!(eventEmitter
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57634233
--- Diff: cordova-common/spec/events.spec.js ---
@@ -0,0 +1,30 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57634064
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/418#discussion_r57632693
--- Diff: cordova-common/src/events.js ---
@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter)
{
if
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/418
CB-10940 Can't add Android platform from path
Added a corresponding test for events.forwardEventsTo
[Jira issue](https://issues.apache.org/jira/browse/CB-10940)
You can merge this
10 matches
Mail list logo
