Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205
@csantanapr, i merged a bit different change, which uses `preparePlatforms`
method instead of `prepare` .It is a subset of `prepare` but doesn't include
th
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380
@vladimir-kotikov yes lets fix this in cordova-lib to get a fix in CLI
6.1.1, but I agree with you that problem should also be fix in iOS
The root of t
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201929790
@csantanapr, this LGTM and i believe it would solve the problem, but I
think the real problem is in cordova-ios `prepare` method - when you change
app's na
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201893339
@riknoll @vladimir-kotikov I found a way to skip prepare hooks on first
prepare call. made the change I rebase, please review again
---
If your project is set u
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201881251
@riknoll I don't think is big deal if prepare hooks twice, I will look to
see if there is a way to call first prepare without hooks
---
If your project is set u
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/416#issuecomment-201642371
Does running prepare twice have any impact on the hooks that fire?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/416
CB-10961 Error when adding ios platform and plugin declare in config.xml
@vladimir-kotikov can you review
This other commit
https://github.com/apache/cordova-lib/commit/3b9face5187857d3
