[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/417#discussion_r57614805 --- Diff: cordova-common/spec/util/xml-helpers.spec.js --- @@ -207,6 +207,16 @@ describe('xml-helpers', function(){ expect(test

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/417#issuecomment-202528558 LGTM. Didn't have a time to test it but making `name` a singleton definitely makes sense. --- If your project is set up for it, you can reply to this emai

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

2016-03-26 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/417 CB-10965 xml helper allows multiple instances to be merge in config.xml @vladimir-kotikov I this is the real fix on duplicate names ending up in final config.xml triggering the unwanted rena