Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217283363
Great! Thanks @jasongin! Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217281613
As discussed, I tested this with symbolic links both at the root and in a
subdirectory. It works fine without any special symlink handling in the code.
---
If you
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217236642
@nikhilkh waiting on you. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216628696
Okay, thanks for clarifying. I rescind my objection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216624907
If you're talking about a source file, then that would change the
last-modified timestamp of the source file, causing it to be newer than the
target file so it wil
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216619728
Is it possible that a change to a file without affecting file size could go
undetected?
---
If your project is set up for it, you can reply to this email and
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216618237
BTW, I didn't mention above the reason I had to abandon the approach of
checking for exactly-equal modified times. The problem is the OS X filesystem
doesn't suppo
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216617718
@purplecabbage If a hook fails because it expected a file would be
refreshed but it wasn't, then I'd expect the hook to print an error (or stack
trace), so that sh
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216611405
All right, I think this is the best we can do. The latest logic copies the
file if the source's last-modified time is >= the target's last-modified time,
or if the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216614096
I would not consider that contrived.
This would be an extremely tough issue to find if it happened.
---
If your project is set up for it, you can reply
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216585668
Well, after further testing I found creation dates don't work reliably due
to some strange behavior on Windows:
http://serverfault.com/questions/92757/incorrect-fi
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-216319068
I updated the PR to use target creation times instead of modified-times. It
works much better: it doesn't require the messy workaround on Windows and
doesn't have
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61665459
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61659743
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697
@nikhilkh As we discussed, this workaround was the best I could find. The
command script approach has similar performance to just copying files via the
node fs API
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215817627
Simultaneously, lets ask libuv to make the fix for this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215780851
I need to add a workaround for the nodejs bug in setting file timestamps on
Windows: https://github.com/nodejs/node/issues/2069
---
If your project is set up for
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215260110
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215255548
@vladimir-kotikov I think this is ready to go after the latest update.
Please let me know if you have any further comments.
---
If your project is set up for it,
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-214812288
## [Current coverage][cc-pull] is **100%**
> Merging [#429][cc-pull] into [master][cc-base-branch] will increase
coverage by **+19.90%**
```diff
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60482215
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481666
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481370
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460847
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460033
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459967
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459281
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60458884
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60452183
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60450430
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60449617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60448617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+o
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60409457
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60407237
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60406393
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399853
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399365
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398700
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398288
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397531
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397076
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396878
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396904
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396886
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60384873
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60314872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or
48 matches
Mail list logo
