Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63577980
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i];
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63474049
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i];
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63441699
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i];
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/440#issuecomment-219013373
Looks like tests are failing due to not yet published
`cordova-common@1.3.0` dependency for `cordova-fetch`
---
If your project is set up for it, you can
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/440
CB-11261 Cut out '-nightly' prerelease tag when checking plugin engines
See the background and explanation at
[CB-11261](https://issues.apache.org/jira/browse/CB-11261)
This P