Github user perilousleigh commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-49034021
Ok my problem was that when I generated my project I was on an earlier
version of the CLI and it did not generate all the land/port drawable
directories. So be
Github user AxelNennker commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-48963855
@perilousleigh
On Android the default splash screen are in the land/port directories.
The example above uses the same directories.
Please add output f
Github user perilousleigh commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-48961753
After checking the code it doesn't look like it's expecting the "land" or
"port" prefixes in the density attribute. So removing the orientation prefix
and just
Github user rohitagg28 commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46936636
I have remove this line
from config.xml file and added these to it.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
I ran jshint manually on the changed files and amended ConfigParser.js
which jshint complained about.
Axel
2014-06-20 22:06 GMT+02:00 Axel Nennker :
> I ran npm test but get a bunch of other errors. No idea what is wrong.
> Axel
>
> > npm run jasmine && npm run jshint
>
>
> > cordova-lib@0.21.4-
I ran npm test but get a bunch of other errors. No idea what is wrong.
Axel
> npm run jasmine && npm run jshint
> cordova-lib@0.21.4-dev jasmine /host/Cordova/cordova-lib/cordova-lib
> jasmine-node --color spec-plugman spec-cordova
...
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46689209
For this particular PR. Thanks for fixing the indentation.
With JSHint added yesterday, "npm test" now runs JSHint on all the files.
Please run it and fix the JSHin
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46688510
The "Merge remote..." commits are not that horrible, we have plenty of
those in our repos and they have some benefits. But if you want to avoid them,
try some of the b
Github user AxelNennker commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46670164
@jsoref How do I do the rebase to get rid of "Merge remote-tracking branch
'upstream/master'" commits.
I wrecked my other repo (for cordova-cli) so I am cautio
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46646255
Could we also incorporate the following PR to this one before merge? It
adds splash images support for iOS, WP8 and Windows8.
https://github.com/AxelNennker/cordo
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46631067
Could you please do a rebase so that there isn't an ugly merge (or multiple
ugly merges) in the history? I've done a number for #9 -- it makes things much
nicer.
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/30#discussion_r13974255
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -88,13 +88,54 @@ module.exports.prototype = {
fs.writeFileSync(this.strings
Github user surajpindoria commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46506676
Can you add some tests for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46172077
@AxelNennker ok, i started with WP8, Windows8 and iOS implementations,
based on your work here: https://github.com/MSOpenTech/cordova-lib/tree/CB-3571.
---
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46170707
Here is proposal for standartized splashscreen support across platforms:
https://gist.github.com/vladimir-kotikov/875a5f61a88a508d6ca9
---
If your project i
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46166927
@AxelNennker, thx for the clarification!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user AxelNennker commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46165459
The current code does not remove the default cordova splash screens if
there are any but there is no in config.xml
I think the default splash screens should n
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371
The usage LGTM. But does current implementation remove all default cordova
splash screen images if there is no splash element defined?
Also, on Android icons and
Github user AxelNennker commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46097179
Tested with this config.xml
The paths t
GitHub user AxelNennker opened a pull request:
https://github.com/apache/cordova-lib/pull/30
CB-3571: support for element in config.xml on Android
This PR implements CB-3571 Add support for elements in config.xml
on Android
You can merge this pull request into a Git repository by
21 matches
Mail list logo
