[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

2015-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

2015-01-27 Thread Mitko-Kerezov
Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-lib/pull/151#issuecomment-71607363 Hey @shazron can you take a look at this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

2015-01-20 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/151#discussion_r23238546 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -184,22 +184,16 @@ module.exports = { var xcodeproj = xcode.project(pbxPath);

[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

2015-01-20 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/151#discussion_r23237848 --- Diff: cordova-lib/src/plugman/platforms/ios.js --- @@ -29,8 +29,8 @@ var path = require('path') , plist = require('plist') , shell = requi

[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

2015-01-20 Thread Mitko-Kerezov
GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-lib/pull/151 CB-5696 find ios project directory using the xcode project file Add unit tests for future reassurance Fix incorrect name "ChildApp" in .pbxproj files to "SampleApp" Related to http