Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-162125224
Merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-159824863
@stevengill do you think this can be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-155330596
Rebased on latest master and now tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-152079604
Failing tests!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-150069617
It looks good to me. It is essentially just fixing `parent=true`
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795
@stevengill Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/289
CB-6698 Fix directory resolution of framework with parent
Due to a refactoring after the original implementation the installation of
plugins containing frameworks with parent=true were broke
