[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...

2014-06-13 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-lib/pull/26#issuecomment-45991316 cool - I think we need to document it in details --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...

2014-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...

2014-06-12 Thread rodms10
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-lib/pull/26#issuecomment-45930663 Yeah, the priorities are pretty messy right now. Currently content in `config.xml` takes precedence on all manifest properties, except two: `permissions` and

[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...

2014-06-11 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-lib/pull/26#issuecomment-45706042 r+ after answering the question of priority of the icons set --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...

2014-06-10 Thread rodms10
GitHub user rodms10 opened a pull request: https://github.com/apache/cordova-lib/pull/26 CB-6895 Add more config properties into manifest Added `fullscreen`, `orientation` and `launch_path` to the manifest. Plus clean up and indentation. @zalun, can you take a look? You can merge