[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-15 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-79026418 This is merged in https://github.com/apache/cordova-lib/commit/b03b4d7ddec982b00e6f009468ffa8db59c56e1c. @omefire could you please close this --- If your

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/184#discussion_r26392721 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -185,8 +185,9 @@ module.exports = function plugin(command, targets, opts) {

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446 @vladimir-kotikov Can you please help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-10 Thread glasser
Github user glasser commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-78213647 Awesome, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-10 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/184 CB-7698 BugFix: For plugins which require variables, 'cordova plugin add FOO' should fail when no variables specified. CB-7698 BugFix: For plugins which require variables, 'cordova plugin add