Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-72642965
Here's a pull request for the fix of the afore-mentionned bug :
https://github.com/apache/cordova-lib/pull/159
---
If your project is set up for it, you can reply t
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-72637685
Hey @agrieve, It seems like the refactoring you did before merging this in
introduced a bug :
Suppose the latest android version is: 3.7.0 and my project co
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/141#issuecomment-72557870
I think we don't need this anymore as the functionality this PR wanted to
introduce has already been included here :
https://github.com/apache/cordova-lib/commit/811
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-71510326
Merged this in after cleaning up merge / rebase issues (and some minor
fixups from some testing)
---
If your project is set up for it, you can reply to this email a
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-71294157
it's a merge issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-71293539
Tests are passing locally, so is jshint. I don't know why travis isn't
picking up my changes.
---
If your project is set up for it, you can reply to this email and
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488733
--- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
@@ -26,7 +26,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
request = require
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488149
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions;
exports.addModuleProperty = addModuleP
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23488114
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath,
opt_wrap, opt_obj) {
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23428777
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -71,102 +72,98 @@ function add(hooksRunner, projectRoot, targets, opts) {
// The "plat
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23409016
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -262,3 +270,81 @@ function addModuleProperty(module, symbol, modulePath,
opt_wrap, opt_obj) {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23408933
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -423,7 +420,7 @@ function platform(command, targets, opts) {
// Neither path, nor pl
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23408840
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -71,102 +72,98 @@ function add(hooksRunner, projectRoot, targets, opts) {
// The "plat
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23408671
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -71,102 +72,98 @@ function add(hooksRunner, projectRoot, targets, opts) {
// The "plat
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23408346
--- Diff: cordova-lib/spec-cordova/lazy_load.spec.js ---
@@ -26,7 +26,8 @@ var lazy_load = require('../src/cordova/lazy_load'),
request = require
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23408256
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -55,6 +61,8 @@ exports.preProcessOptions = preProcessOptions;
exports.addModuleProperty = addModuleP
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23330749
--- Diff: cordova-lib/spec-cordova/util.spec.js ---
@@ -183,4 +184,138 @@ describe('util module', function() {
expect(res.indexOf('CVS'))
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23330721
--- Diff: cordova-lib/src/cordova/lazy_load.js ---
@@ -284,4 +286,47 @@ function custom(platforms, platform) {
});
}
+// Returns a
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23130176
--- Diff: cordova-lib/spec-cordova/util.spec.js ---
@@ -183,4 +184,138 @@ describe('util module', function() {
expect(res.indexOf('CVS'))
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23130172
--- Diff: cordova-lib/spec-cordova/util.spec.js ---
@@ -183,4 +184,138 @@ describe('util module', function() {
expect(res.indexOf('CVS'))
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23130079
--- Diff: cordova-lib/src/cordova/lazy_load.js ---
@@ -284,4 +286,47 @@ function custom(platforms, platform) {
});
}
+// Returns a
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r23130053
--- Diff: cordova-lib/src/cordova/lazy_load.js ---
@@ -284,4 +286,47 @@ function custom(platforms, platform) {
});
}
+// Returns a
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-70015916
Task for docs update : https://issues.apache.org/jira/browse/CB-8308
I'll probably send another PR for that by the end of the week.
---
If your project is set up
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22904360
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
});
});
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22900366
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) {
}
ret
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/148#discussion_r22900311
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
});
});
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/148#issuecomment-69831696
please ensure there's a PR to update:
https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20
---
If your projec
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/148
CB-8239 Add support for git urls to 'cordova platform add'
CB-8239 Add support for git urls to 'cordova platform add'
These changes allow the following scenarios:
*users can is
Github user hstaudacher commented on the pull request:
https://github.com/apache/cordova-lib/pull/141#issuecomment-69304587
@omefire I reviewed the change. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/141#issuecomment-69271082
@hstaudacher, I've added the remaining scenarios.
I've copied over some of the changes you made in this branch and merged
them with mine.
I'd be grateful
Github user hstaudacher commented on the pull request:
https://github.com/apache/cordova-lib/pull/141#issuecomment-68684333
I have no idea why the AppVeyor tests are not passing. On my machine and on
travis everything seems to be fine. Maybe the fail is unrelated?
---
If your project
Github user hstaudacher commented on the pull request:
https://github.com/apache/cordova-lib/pull/141#issuecomment-68683461
In issue CB-8239 @omefire suggested 3 features ti be added. This pull
request implements one: 'cordova platform add GIT_REPO'
---
If your project is set up for
GitHub user hstaudacher opened a pull request:
https://github.com/apache/cordova-lib/pull/141
CB-8239 Add support for git urls to 'cordova platform add'
A function called 'cordova_custom_git' was added to lazy_load.js. When
invoking 'cordova platform add GIT_REPO' this function w
35 matches
Mail list logo
