[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75669608 @gorkem, I did find some things that needed to be updated in restore-util.js. those have been taken care of. --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75660844 @gorkem, cool. working on a rebase + update to new dependent modules ... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-23 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75658796 @omefire this looks OK and would like to get it in. The dependencies have changed though save.js and restore.js are gone. I could not quickly spot anything on platfor

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-20 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75346177 There will need to be another pass to update dependent modules to handle the possibility that some new code depending on old syntax might have been inserted in the i

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-19 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-75103410 I wonder if it is worth to do an auto convert from old syntax when we encounter it? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-17 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/168#issuecomment-74720162 CB-8482: Update engine syntax within config.xml - from : `` - to : `` --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-lib pull request: CB-8482: Update engine syntax within con...

2015-02-16 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/168 CB-8482: Update engine syntax within config.xml CB-8482: Update engine syntax within config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.