Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284601
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -278,9 +283,16 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284603
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -295,14 +307,87 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284597
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -234,7 +239,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284609
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -144,7 +144,10 @@ function fetchPlugin(plugin_src, plugins_dir, options)
{
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284638
--- Diff: cordova-lib/src/plugman/util/metadata.js ---
@@ -59,3 +59,10 @@ exports.save_fetch_metadata = function(pluginsDir,
pluginId, data) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284598
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -267,7 +271,8 @@ module.exports = function plugin(command, targets,
opts) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-78182770
Thanks for raising this issue, @gorkem. I just pushed some changes to
handle `dependent` plugins and only save `top-level` plugins in config.xml.
---
If your
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26058485
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -134,7 +135,7 @@ module.exports = function plugin(command, targets,
opts) {
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77955805
I think this saves **all** the installed plugins to config.xml. The
dependency plugins ( those plugins that were installed as a dependency of
another) should never
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77955992
Interesting. @gorkem, could you give an example of a plugin that has
dependency plugins ? I'll carry some testing regarding that.
---
If your project is set up for
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26082685
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -284,6 +284,11 @@ module.exports = function plugin(command, targets,
opts) {
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77956329
I was just testing com.ibm.mobile.cordova.ibmpush for something else which
seems to pull in another large plugin
---
If your project is set up for it, you can reply
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/178
CB-8521 `cordova plugin save` should save all installed plugins and their
version/git-url/folder-location into config.xml
CB-8521 `cordova plugin save` should save all installed plugins and
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/178#issuecomment-77661119
@vladimir-kotikov , please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
15 matches
Mail list logo
