Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-86994521
Yes, #191 subsumes this PR. I believe @omefire is on vacation and he will
be able to close this when he's back.
---
If your project is set up for it, you can reply
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-86993019
Was this all taken care of with #191 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/191#issuecomment-86991348
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-86228108
This PR needs to be closed as it is a dup of #191.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/191
CB-8596 Expose APIs to retrieve platforms and plugins from config.xml
Provides third parties access to platform and plugin information stored in
`config.xml` without having to go through Conf
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152048
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152050
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26150341
--- Diff: cordova-lib/spec-cordova/project-metadata-apis.spec.js ---
@@ -0,0 +1,85 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-78115338
I noticed that the plugin metadata that is exposed is the id and version
number. What if the source is a git URL - how is that exposed?
---
If your project is set
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26143818
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25840412
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25839537
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-77288127
Looks like your new tests are timing out and you might need to increase the
timeout value.
---
If your project is set up for it, you can reply to this email and ha
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25831932
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25831848
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-77117803
hmmm, the build failure is something that seem to happen randomly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-77107191
@agrieve , @stevengill please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-77107166
After migrating platforms & plugins to package.json, This implementation
will be updated, but clients will remain unchanged.
---
If your project is set up for it, y
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/177
CB-8596 Expose APIs to retrieve platforms and plugins saved in config.xml
CB-8596 Expose APIs to retrieve platforms and plugins saved in config.xml
so as to abstract clients away from the conf
21 matches
Mail list logo
