[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/179#issuecomment-78072159 Tested, works fine. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/179#issuecomment-77910727 Yes, I have plans to add automated tests for this scenario. I had some tests for this scenario a while back :

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-09 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/179#issuecomment-77905654 Can we add tests for this scenario? This looks like a regression and there is not test coverage for this scenario. --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/179#issuecomment-77914073 @agrieve , Please, could you review this and potentially merge this ? It fixes a regression that appeared after recent refactoring in `cordova platform add`

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/179#issuecomment-77963632 @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-8633 BugFix: Support for urls to tarb...

2015-03-08 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/179 CB-8633 BugFix: Support for urls to tarballs was broken CB-8633 BugFix: Support for urls to tarballs was broken You can merge this pull request into a Git repository by running: $ git