[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-16 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-81875689 @omefire Could you please delete MSOT branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-11 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-78387046 closing this PR because #182 went in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-11 Thread omefire
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-10 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-78145771 Please close this PR if #182 supersedes this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-78151471 Let's wait until PR #182 goes in ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-10 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-78150199 Not until PR #182 goes in ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/181 CB-8636 Remove FEATURE_SPECIAL_PARAMS from feature.variables list CB-8636 Remove FEATURE_SPECIAL_PARAMS from feature.variables list You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-77969339 Should we close this? #182 removes all this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-77963529 @vladimir-kotikov , could you please review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-lib pull request: CB-8636 Remove FEATURE_SPECIAL_PARAMS fr...

2015-03-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/181#issuecomment-77997261 Yes, the pull request https://github.com/apache/cordova-lib/pull/182 makes these changes unecessary. --- If your project is set up for it, you can reply to this