Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126740006
@TimBarham , I've explored that possibility before landing with the current
solution.
I think messing around with a queue-based solution or the event loop is
go
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126738584
@TimBarham , I've explored that possibility before landing with the current
solution.
I think messing around with a queue-based solution or the event loop is
go
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126670748
Made this comment offline, but decided it should be included here too... I
don't think this is the right fix - I think a more general approach would serve
use bet
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126643184
Also tried on OS X with two platforms, and it worked. +1 for adding a test
case for this.
---
If your project is set up for it, you can reply to this email and ha
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126519728
Thinking about it - wonder if you can add test case for this to prevent
future regression. It's really a basic use case here.
---
If your project is set up for it
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126516900
@nikhilkh , it's ready to be merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-126516413
@omefire - Is this ready to be merged? It will be good to get this merged
before the next cordova-lib release.
---
If your project is set up for it, you can reply
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/266#discussion_r35200762
--- Diff: cordova-lib/src/util/promise-util.js ---
@@ -33,4 +33,21 @@ function Q_chainmap(args, func) {
});
}
+// Behaves
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/266#discussion_r35200567
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -56,24 +57,23 @@ function installPlatformsFromConfigXML(platforms) {
if (!targe
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-123661743
LGTM. I would also avoid unnecessary whitespace and formatting changes.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-123498882
@nikhilkh, log level updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/266#issuecomment-123493951
One small comment. LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/266#discussion_r35160288
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -56,24 +57,23 @@ function installPlatformsFromConfigXML(platforms) {
if (!targets || !t
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-lib/pull/266
CB-9278: BugFix: Restoring multiple platforms fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-9278
Alterna
15 matches
Mail list logo
