Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-141170683
:+1: @vladimir-kotikov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140734415
Sent a PR to node-xcode with suggested fix:
https://github.com/alunny/node-xcode/pull/66
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140061087
@vladimir-kotikov yes change to node-code looks good send the PR to see
what they want to do, we don't have to wait for a new node-xcode since we
switched cordov
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140060717
We need to merge and release fast cli and lib with this bug, nodejs@4 is
out and this is a major bug
---
If your project is set up for it, you can reply to thi
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140060516
@vladimir-kotikov yes, This PR is good to merge to cordova-lib, that's what
I meant with "I agree with the change then..." :-)
:+1:
---
If your projec
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-140033673
Ok, so this PR could be merged then?
Regarding fix for node-xcode, could you please take a look at
https://github.com/vladimir-kotikov/node-xcode/c
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139655827
Thanks for explanation @vladimir-kotikov and thanks for your input @pmuellr
I agree with the change then after explanation.
I still think it should b
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139631229
@csantanapr re: not a fan of sync in node.js
Sync becomes a problem if you're wasting precious cycles in a single
operation, instead of using async to pote
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139556202
The `xcode`'s `parse` method uses `child_process.fork` API to run parser in
a separate worker process, which then reports parsing result to parent process
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139555231
If it's something wrong with npm package xcode, we should open an issue and
maybe help with a PR
---
If your project is set up for it, you can reply to this em
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139548204
Hi @vladimir-kotikov can you give explanation why the fix is to run Sync?
In general I'm not fan on Sync in nodejs, but would like to understand
what's t
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139524490
@nikhilkh, i've reworked tests for ios_parser so they work with real xcode
project instead of mocking it.
Regarding second question - yes, all the
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139314186
I will test it out today. I agree about doing a minor tools release with
this fix.
---
If your project is set up for it, you can reply to this email and have y
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139294305
@vladimir-kotikov Are there tests that break with this scenario failure or
should we take the opportunity to add some here - not sure how easy that might
be. Also,
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139293826
This is a good one to fix. We might need a minor TOOLS release to get this
out as node v4.0.0 might become popular. @stevengill Thoughts?
---
If your project is s
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/305
CB-9297 Parse xcode project syncronously to avoid issues with node v4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/c
17 matches
Mail list logo
