Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/265#issuecomment-122602056
Awesome ! Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/265#issuecomment-122583017
Yeah. I'll add it to the docs too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/265#issuecomment-122580433
@purplecabbage LGTM !
But could you also add a comment to specify all the forms that 'git_ref'
could assume ? (branch, commit SHA, etc...). That might prevent at
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/265#issuecomment-122580399
I wasn't a fan of the `cryptic` optimizations we were doing to begin with,
as it rendered the code more cryptic than it needed to be.
---
If your project is set up
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/265
CB-9384 Plugman should be able to checkout a commit SHA
actually checkout git_ref because it may be a branch OR a commit SHA
This functionality was lost when CB-8908 was implement
