Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-138107803
@purplecabbage This one did close itself. (asfgit closed it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-137920543
@omefire These pull requests should just close themselves if you merge->push
Are you rebasing?
---
If your project is set up for it, you can reply to th
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-137900148
Merged !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135899844
LGTM ! @marcuspridham, I'll pull these changes in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135899446
@dpogue , I see what's going on there. This might call for us to be able to
handle dependent plugin's versioning in Cordova.
---
If your project is set up for it,
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135892414
I see. The parallel mode exhibits a race condition with regards to this
check :
[platformJson.isPluginInstalled](https://github.com/apache/cordova-lib/blob/bed6d3a2
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135886715
In serial it seems to be able to detect the file plugin is already
installed and does not try to install it again. The parallel way you can see
in the logs t
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135884862
A related issue about dependency versions from config.xml not being
respected when they are dependencies of another plugin is
[CB-9525](https://issues.apache.org/jir
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135884296
This issue arises because [common.copyFileNew]
(https://github.com/apache/cordova-lib/blob/dff78b0779444d06e259140694e07d5e8c5f5308/cordova-lib/src/plugman/platforms
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135883628
This issue arises because [common.copyFileNew]
(https://github.com/apache/cordova-lib/blob/dff78b0779444d06e259140694e07d5e8c5f5308/cordova-lib/src/plugman/platforms
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135883534
This issue arises because [common.copyFileNew]
(https://github.com/apache/cordova-lib/blob/dff78b0779444d06e259140694e07d5e8c5f5308/cordova-lib/src/plugman/platforms
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135879399
Cool @marcuspridham . thanks for the confirmation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135579250
Yep it does seem to happen with cordova-plugin-file-transfer and
cordova-plugin-file. I added the following to the default cordova project
config.xml and add
Github user marcuspridham commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135566988
Added comments. I'll try to put together a sample that shows the issue.
The ones I am using are not available on NPM.
---
If your project is set up for it,
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135565178
Also, does this happen when you use the following two plugins :
cordova-plugin-file and cordova-plugin-file-transfer ?
Otherwise, could you please provide some e
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135564467
Also, does this happen when you use the following two plugins :
cordova-plugin-file and cordova-plugin-file-transfer ?
Otherwise, could you please provide some e
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135557411
@marcuspridham, could you please add a comment like the one added for
CB-9278 ?
That way, we could signal other devs not to try and optimize this piece of
code
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135556631
@marcuspridham, could you please add a comment like this one ?
That way, we could signal other devs not to try and optimize this piece of
code by parallelizing i
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/288#issuecomment-135300595
@omefire to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
GitHub user marcuspridham opened a pull request:
https://github.com/apache/cordova-lib/pull/288
CB-9560 Issue using plugin restore for plugins with common dependencies
Similar change to CB-9278. This change makes it so only one plugin is
restored at a time.
You can merge this pull
21 matches
Mail list logo
