Github user stevengill closed the pull request at:
https://github.com/apache/cordova-lib/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/313#issuecomment-146080750
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/313#issuecomment-145759968
@stevengill, looks good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/313#issuecomment-145705106
@vladimir-kotikov switched to warnings and added some verbose output. Also
added a conversion step to fetch.js as it was needed in there since cordova-lib
calls
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121964
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -142,8 +143,17 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121974
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -256,6 +266,15 @@ function runUninstallPlatform(actions, platform,
project_dir, plugin_dir
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121721
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -404,6 +418,20 @@ function installDependencies(install, dependencies,
options) {
re
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/313#discussion_r41121704
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -79,6 +80,19 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_d
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/313
CB-9589 auto convert IDs to new style IDs if in registry mapper
@nikhilkh @vladimir-kotikov take a look. Thoughts?
You can merge this pull request into a Git repository by running:
$ gi
