[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-20 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141781606 :+1: - reviewed `cordova-common` folder, run `npm install` and `npm test` --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141607056 sounds great, @vladimir-kotikov - I plan to complete this on weekend --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141443929 @sgrebnov, this is ready to merge, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/309#issuecomment-141443458 @nikhilkh, regarding your concern about iOS specific dependencies (`xcode`, `plist` and `bplist-parser`) for this - the reason is that `ConfigChanges` clas

[GitHub] cordova-lib pull request: CB-9598 Introduces `cordova-common` modu...

2015-09-16 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/309 CB-9598 Introduces `cordova-common` module This is an implementation for [CB-9598](https://issues.apache.org/jira/browse/CB-9598) and the next step of platformApi refactoring. The ide