[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/300#issuecomment-138789580 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/300#issuecomment-138632174 Problem w/ tests is that we have e2e tests but they miss windows10 proj target. Since I've added more functionality and corresponding tests (+ missing windows10 pr

[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/300#issuecomment-138602675 It will be great to add test cases for this scenario. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-lib pull request: CB-9601 Fix .versions support...

2015-09-08 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/300 CB-9601 Fix .versions support on Windows after semver update https://issues.apache.org/jira/browse/CB-9601 Adds logic to convert Windows specific four-digits version to three-digits s