Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147529842
looks good to me. Thanks @daserge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147529120
@shazron, could you please review again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147459012
Got it, thanks for the explanation, @shazron.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147457505
They do the same thing, almost. The only thing different is access tags do
not handle wildcards in the schemes. I've opted to keep them separate for
completeness, a
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147455513
Don't these tests do the same thing?
Or is there any state changing between tests I'm missing?
---
If your project is set up for it, you can reply to this email
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147454277
No, its correct. The two tags are different.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147453617
@shazron, could please explain the difference in these tests? Is there a
typo?
[`it(' - should handle
wildcard')`](https://github.com/apache/cordova-lib/commit/
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147451673
Sure, I'm looking into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147449612
Great, since you've identified the stuff that crashes, you should add tests
for them in the jasmine tests (there are already tests for other cases).
---
If your pr
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147447268
BTW `` and `` don't crash and result in
```xml
null
NSExceptionAllowsInsecureHTTPLoads
```
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-147445435
The current code results in such an entry in `mobilespec-Info.plist`:
```xml
```
This happens with mobilespec `config.xml`' [``]
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-146993120
Just a question, this is for the case for example: `http://*` or
`https://*` correct? A failing test should be added to the existing tests.
---
If your project is
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/318#issuecomment-146539223
@shazron, could you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/318
CB-9758 Mobilespec crashes adding plugins on OS X
Avoid empty keys in NSExceptionDomains
[Jira issue](https://issues.apache.org/jira/browse/CB-9758)
You can merge this pull request int
15 matches
Mail list logo
