[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152446226 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152495853 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152467126 Merged in https://github.com/apache/cordova-lib/commit/b52c257fcde22e982aea7b2287b3d0b943b16df2 --- If your project is set up for it, you can reply to

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-29 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/329#issuecomment-152275664 Closing and reopening to trigger the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-29 Thread vladimir-kotikov
GitHub user vladimir-kotikov reopened a pull request: https://github.com/apache/cordova-lib/pull/329 CB-9834 Introduce cordova modules compatibility map for plugin hooks This fixes potential issue with third-party plugin hooks, since many of them using internal cordova modules, in

[GitHub] cordova-lib pull request: CB-9834 Introduce cordova modules compat...

2015-10-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/329 CB-9834 Introduce cordova modules compatibility map for plugin hooks This fixes potential issue with third-party plugin hooks, since many of them using internal cordova modules, in