[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-03 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153361722 sounds good. thanks @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-11-02 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-153214572 Lets merge this in after the 5.4.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152646051 I think is a nice feature to open the browser to a good spot on the wen to search for plugins applicable for cli use cases where people are running by hand when

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152612090 Are people likely to be doing a plugin search from a gulp script? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152611628 @omefire I've started a discussion thread for this on the dev list --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152610676 What about people who use Cordova-lib from gulp instead of the cli ? Does it make sense to pop open a browser window ? --- If your project is set up for it, you

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152596207 Thanks @nikhilkh! I'll take a look at the jshint failure and fix it --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-30 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/334#issuecomment-152566519 LGTM this is a good one to fix. There is a jshint failure though that you might want to fix. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-9901 cordova plugin search opens in a...

2015-10-29 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-lib/pull/334 CB-9901 cordova plugin search opens in a browser You can merge this pull request into a Git repository by running: $ git pull https://github.com/eymorale/cordova-lib CB-9901 Alternative